Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing user warnings for deprecated methods. #128

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Added missing user warnings for deprecated methods. #128

merged 1 commit into from
Aug 1, 2017

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Jul 28, 2017

No description provided.

@fvgh fvgh requested a review from nedtwigg July 28, 2017 20:44
@fvgh
Copy link
Member Author

fvgh commented Jul 28, 2017

I see no evidence that the approach is wrong as it has been also taken for #109, and I am not able to reproduce it.
As far as I get no further feedback, I leave the code as it is.
Feel free to merge if this code change looks good to you.

@nedtwigg nedtwigg merged commit 6a3f8ad into master Aug 1, 2017
@fvgh fvgh deleted the importOrderVarargs branch August 7, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg nedtwigg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvgh @nedtwigg